feat!: add support to publish to huawei store#1475
Conversation
JohanLorenzo
left a comment
JohanLorenzo
left a comment
There was a problem hiding this comment.
LGTM! 👍 As rightfully documented in pushapkscript/pyproject.toml, this depends on mozilla-releng/mozapkpublisher#325. I'm approving it because I don't believe this PR is going to change a lot so no need for my approval again to get it landed.
One more question: how did the testing go beyond the unit tests in this PR?
| skip_check_multiple_locales=True, | ||
| skip_check_ordered_version_codes=False, | ||
| skip_check_same_locales=True, | ||
| skip_checks_fennec=True, |
There was a problem hiding this comment.
Doesn't block the merge: What are the reasons for skipping the Fennec checks? For reference, this is what they do:
This flag was introduced in mozilla-releng/mozapkpublisher#156 to support more products than Firefox itself. Firefox for Android has its quirks compare to simpler apps.
| "Programming Language :: Python :: 3.11", | ||
| ] | ||
| dependencies = [ | ||
| # TODO: bump to >=12.0.0 once mozapkpublisher 12.0.0 (huawei store) is on PyPI |
There was a problem hiding this comment.
Question: what was your experience between mozapkpublisher and pushapkscript? Did the split make it easier to test changes locally? If you were to implement a worker that publishes to Android stores, would you split these 2 packages?
I don't have any preferences in the answer, I just want to gauge if this split is still worth it today.
2 participants
No description provided.